New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RandomCharField - Prepopulates random character string. #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you please take a look at why the tests are failing ? |
Its from this
I'll fix and try to increase coverage. |
1 similar comment
Ready to merge ? |
Yeah this is it. |
Sorry I have been changing history to keep the commit clean. That is why its rebuilding. |
- Factored out query logic to ensure uniqueness to BaseUniqueField. - The field value factories have been moved to generators.
1 similar comment
trbs
added a commit
that referenced
this pull request
May 21, 2015
RandomCharField - Prepopulates random character string.
Thanks !! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added support for a random character field. Its purpose is to create an unique id unrelated to the database id to prevent site walking and sequential attacks on something like a unsubscribe link. A sample use case would be a link shortening service like bit.ly, http://bit.ly/1AbL4UC.
Non-Breaking changes:
Possibly breaking change:
Please let me know your comments and feedback. I enjoyed working on this code very much!