New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoSlugField: fix allow_duplicates #922

Merged

trbs merged 1 commit into django-extensions:master from beshrkayali:allow_duplicates_fix

Jun 30, 2016

Contributor

beshrkayali commented Jun 28, 2016

Resolves #801

The issue is that if allow_duplicates is True, create_slug will return the slug directly without setting the attribute (field name) on the model instance. find_unique takes care of this in case allow_duplicates is False or not set.


          Set attr attname when allow_duplicates is True so model instance ge…

3ce5e09

…ts a value after slug generation

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

19 similar comments

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

coveralls commented Jun 28, 2016

Coverage decreased (-0.005%) to 32.438% when pulling 3ce5e09 on beshrkayali:allow_duplicates_fix into 3f63697 on django-extensions:master.

trbs merged commit dca6986 into django-extensions:master

Member

trbs commented Jun 30, 2016

Thanks !

beshrkayali deleted the allow_duplicates_fix branch

July 1, 2016 13:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment