Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selector-search.gif missing #1221

Closed
bctiemann opened this issue Jul 19, 2018 · 2 comments · Fixed by #1234
Closed

selector-search.gif missing #1221

bctiemann opened this issue Jul 19, 2018 · 2 comments · Fixed by #1234

Comments

@bctiemann
Copy link

widgets/foreignkey_searchinput.html has the following:

<img src="{% static "admin/img/selector-search.gif" %}" width="16" height="16" alt="{% trans "Lookup" %}" />

But there is no such image in the statics.

@arthurio
Copy link

arthurio commented Aug 7, 2018

It's a long time known bug (see #229 and #786).

Since at least Django 1.9 (I don't know for previous versions), the related-lookup class will get the image icon from the Django css:

.related-lookup {
    width: 16px;
    height: 16px;
    background-image: url(../img/search.svg);
}

So I think we can simply drop the img tag altogether.

I'd be happy to submit a PR but I'm not sure what are the expectations in terms of compatibility with older versions of Django. Also, I'm not sure we can really test the change? Maybe it's not super important since it has been broken for so long?

@trbs
Copy link
Member

trbs commented Aug 7, 2018

Anything that improves the situation is a step forwards :-)

For Django Extensions we (officially) follow Django in which releases we support, which currently is Django 1.11 and up.

I think what your suggesting is good and happy to merge the PR if you would be so kind to create that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants