Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save the parent info with threadedcomment #24

Closed
liuzg opened this issue Jul 16, 2013 · 3 comments
Closed

Can't save the parent info with threadedcomment #24

liuzg opened this issue Jul 16, 2013 · 3 comments

Comments

@liuzg
Copy link

liuzg commented Jul 16, 2013

Hi, I tried the example with threaded comment, and found that it can't show the hierarchy in the right way. And i confirmed the comment data with admin, found that the parent info hasn't been saved.

@liuzg
Copy link
Author

liuzg commented Jul 22, 2013

The program is fine.
Got the reason now. It's because of the Jquery version. According to
theme1/templates/theme1/base.html, there is " src="{{ STATIC_URL }}admin/js/jquery.js" ",
I fount in my PC, the jquery.js is 1.4.2, and the .data() method is available from 1.4.3.
When I changed the jquery lib, it can be used rightly.

@vdboor
Copy link
Contributor

vdboor commented Jul 22, 2013

Ahh, thanks for the feedback. That's useful to know.

For compatibility with older jQuery versions, I've used .attr('data-...') often. Seems like a good idea to use that over here too!

@vdboor
Copy link
Contributor

vdboor commented Apr 3, 2014

The app uses .attr('data-..') now. thanks for the report!

@vdboor vdboor closed this as completed Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants