New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptations for Solr 5.0.0 #1148
Conversation
+1, need to try this out... |
I think I fixed the failed test (Python 3 compat). The merge should be faisable now. Thanks |
@elishowk I think you need to rebase this PR. |
Rebasing it would be much appreciated |
Rebased on the master and squashed my commit in one commit for this feature. Hope this will work for you. |
The tests fails only on one configuration while starting solr testing server on Travis-ci. Don't know what to do, this is not a test failure I can manage myself ... |
I'd appreciate this getting merged/finalised soon. |
I would too, but I don't know what to do about the travis build, there's only one build that failed because the Solr erver wouldn't start (check 337 in https://travis-ci.org/django-haystack/django-haystack/builds/56762056). Anyway, the tests are OK on my part. |
Can someone restart test? Sounds to me that this one time thing. It relates to solr not code. So maybe it only failed once in that py34-dj1.6 https://travis-ci.org/django-haystack/django-haystack/jobs/56762069 (337.10). |
- deploying Cores with new managed-schema (not schema.xml) and the Schema REST API - edited README and installing_search_engines.rst for both solr 4.10.2 and 5.0.0 - changed build_solr_schema command, plus updated tests
@acdha |
Hi, I've recently rebased tried to make the tests pass completely, but |
I have updated the test suite to test for both Solr 4 and Solr 5. Everything is fine on Travis, except for a Python 3 and Pysolr related issue (PR still waiting django-haystack/pysolr#162) at https://github.com/toastdriven/pysolr/blob/master/pysolr.py#L445 when python 3 need a b'<?xml' to cast to bytes this answer (read https://stackoverflow.com/questions/6269765/what-does-the-b-character-do-in-front-of-a-string-literal/6269785#6269785) Waiting for news from the maintainers from both pysolr and haystack. |
I confirm that @elishowk's version works with Solr 5.3. No schema.xml is needed. Great work, thanks! |
Hi! Since the bug on PySolr is now fixed and someone has confirmed that it all works, can this be merged now? If further testing is needed I'm happy to help. |
We love to have the support and the new release. Looking forward to hearing from main developers. |
This seems to work for me, but following changes in a Am I missing something on my end? |
Hi, I am using haystack field 'edge_ngram' for auto-complete functionality. However, using build_solr_schema fails to add the field with 'edge_ngram' and the fieldtype is also missing from the managed-schema file. Am I missing anything here? Any pointers will be helpful. Thanks |
In Solr 5+, the schema is managed by default via the REST API, not by xml file that does not change when you update the schema via the API. Please read more here the Read-me doc in the pull-request or Solr documentation here |
Your branch should be rebase ;). |
Yep, I will do, but please @acdha could you confirm me that it will be merged rather quickly ? If not, I will wait the owner's signal to work on it. |
@elishowk Yes – if it's a clean branch with test coverage it won't take very long for me to merge & we should ship a release by then, too. |
After rights to access a team's repo, I've forked these commits to my account, and submitted a new PR here #1315 . |
Solr 5.0.0 is easy to deploy with cloud Cores with automatic managed-schema and no more schem.xml.
Solr 5.0.0 can edit a core's configuration via with the Schema REST API.
This is what this pull request does. Along with an updated documentation.
Refers to issue #1147 and try to resolve it...