django.utils.datetime_safe module is removed in Django v5.0

[cclauss]

When we run pytest on our project, we receive:

.venv/lib/python3.11/site-packages/haystack/fields.py:5
  /home/circleci/circleci-workdir/.venv/lib/python3.11/site-packages/haystack/fields.py:5:
  RemovedInDjango50Warning: The django.utils.datetime_safe module is deprecated.
    from django.utils import datetime_safe

https://github.com/search?q=repo%3Adjango-haystack%2Fdjango-haystack%20datetime_safe

• haystack/fields.py
• haystack/backends/whoosh_backend.py
• test_haystack/whoosh_tests/test_whoosh_backend.py

As discussed but not implemented in #1828 @jayvdb

https://docs.djangoproject.com/en/5.0/releases/5.0
https://docs.djangoproject.com/en/5.0/releases/5.0/#features-removed-in-5-0

The undocumented django.utils.datetime_safe module is removed.

• Tested with the latest Haystack release
• Tested with the current Haystack master branch

Expected behavior

No pytest warnings.

Actual behavior

Pytest warnings.

Steps to reproduce the behavior

% pytest

Configuration

• Operating system version:
• Search engine version:
• Python version: 3.11
• Django version: 4.2.5
• Haystack version: master

[benrxv]

Django 5.0 is now out, and this issue now officially is a problem

A link to proposed solution is documented above...

[cclauss]

Agreed. This is blocking our upgrade to Django v5.0.

• https://www.djangoproject.com/weblog/2023/dec/04/django-50-released

django-haystack/haystack/fields.py

Line 5 in eb3f1d5

from django.utils import datetime_safe

https://docs.djangoproject.com/en/5.0/releases/5.0/#features-removed-in-5-0

[benrxv]

Django now uses django.utils.formats.sanitize_strftime_format() to handle what datetime_safe was doing previously.
https://github.com/django/django/blob/0ee2b8c326d47387bacb713a3ab369fa9a7a22ee/django/utils/formats.py#L244

[cclauss]

Are you able to create a PR for that?

[benrxv]

I'm not certain that haystack needs to sanitize the date strings. Django only seems to do this in a few very specific and important instances, and in one instance, django.utils.feedgenerator, they just replaced datetime_safe with python's native datetime.

[cclauss]

Fixed in #1915 but not yet released to PyPI. Workaround for Django v5.0 deployments:
% pip install git+https://github.com/django-haystack/django-haystack.git

[michaelmior]

@cclauss Thanks! Any ETA on a PyPI release?

[Albert-2024]

Fixed in #1915 but not yet released to PyPI. Workaround for Django v5.0 deployments: % pip install git+https://github.com/django-haystack/django-haystack.git

@cclauss thanks :)