Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize should support 'commit' flag as well #191

Closed
dhruvpathak opened this issue Mar 18, 2016 · 4 comments
Closed

Optimize should support 'commit' flag as well #191

dhruvpathak opened this issue Mar 18, 2016 · 4 comments
Labels

Comments

@dhruvpathak
Copy link

The optimize() operation should also allow commit=true/false flag being sent to update().
Currently it only supports waitSearcher, waitFlush, and maxSegments.

def optimize(self, waitFlush=None, waitSearcher=None, maxSegments=None):

can be :

def optimize(self, waitFlush=None, waitSearcher=None, maxSegments=None, commit=True):

@acdha
Copy link
Collaborator

acdha commented Mar 18, 2016

@dhruvpathak sounds good - can you send a pull request?

@dhruvpathak
Copy link
Author

The change is now merged. Is it now available in the pypi package as well ?
https://pypi.python.org/pypi/pysolr/

@acdha
Copy link
Collaborator

acdha commented Apr 11, 2016

@dhruvpathak There will be a release soon but there's a good bit of testing still required – see v3.4.0...master for everything which has changed. If you have spare time to help with review and testing, that would be appreciated.

@stale
Copy link

stale bot commented Jun 5, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 5, 2018
@stale stale bot closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants