Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_per_queue_staff_permissions uses an int as a password #408

Closed
ghost opened this issue Jun 29, 2016 · 0 comments
Closed

test_per_queue_staff_permissions uses an int as a password #408

ghost opened this issue Jun 29, 2016 · 0 comments

Comments

@ghost
Copy link

ghost commented Jun 29, 2016

In test_per_queue_staff_permissions.py ...
Line 13 : IDENTIFIERS = (1, 2)
Line 34 : for identifier in self.IDENTIFIERS:
Line 44 : user.set_password(identifier)

Line 44 sets the test user's password to the int 1 (or 2). This is fine for the django auth backend, however the ldap backend of Peter Sagerson's excellent django-auth-ldap (https://pythonhosted.org/django-auth-ldap/) throws an error when trying to len(password):
TypeError: object of type 'int' has no len()

A password should always be a string, so maybe we should to this:
Line 44 : user.set_password(str(identifier))

@rossp rossp closed this as completed in da5a4dc Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants