Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

czech translation #703

Closed
jachym opened this issue Feb 2, 2019 · 9 comments
Closed

czech translation #703

jachym opened this issue Feb 2, 2019 · 9 comments
Labels
translations Proposed updates to the translations

Comments

@jachym
Copy link
Contributor

jachym commented Feb 2, 2019

I've added Czech translation on Transifex https://www.transifex.com/django-helpdesk/django-helpdesk

what is the next step? Shell we create pull request for it?

@timthelion
Copy link
Collaborator

How can I see this translation? Do I need to log in?

@gwasser
Copy link
Member

gwasser commented Feb 2, 2019

@timthelion yes I think you need to login to transifex to see it.

@jachym Thank you very much for the translation! A pull request is best. There are two things to change.

  1. add the .po/.mo folders to the locale folder in a new subfolder for czech ('cz')
  2. in templates/helpdesk, make a folder 'cz' and add the translated templates there.

@gwasser
Copy link
Member

gwasser commented Feb 2, 2019

You can submit this PR to master branch and I will pull it into develop from there. Thank you!

@gwasser gwasser added the translations Proposed updates to the translations label Feb 2, 2019
@jachym
Copy link
Contributor Author

jachym commented Feb 3, 2019

@gwasser - locale for czech is cs_CZ - there is cs used in django-helpdesk right now (and it coresponds to https://github.com/django/django/blob/master/django/conf/global_settings.py#L62

therefore, I'm going with cs not cz

@jachym
Copy link
Contributor Author

jachym commented Feb 3, 2019

We still do some cleanups but for the record, before I do the pull request, the code is here https://github.com/OpenGeoLabs/django-helpdesk/tree/cs_translation

@timthelion
Copy link
Collaborator

I read over the translations and while I cannot check grammar as I am not a native speaker, everything makes sense.

  • There's a typo here should be "Pouze".

  • Typo here should be "Přestat".

  • You use different words for escalation in different places. Here you use "vyhrocen" and here you use "vyostření" and here you use "zvýšit prioritu". It would be less confusing for users if you chose one word.

  • You use different words for follow up here you use "aktualizace", here "následovníci", here "Navázání", and elsewhere you use "návazností" here or "návazné" here.

  • This translation isn't correct. Ticket CCs allow you to get emails when the ticket is updated. So "Delete Ticket CC" should be "Odhlasit odběr CC z ticketu". Same here and here

  • Typo

Fuzzy translations are evil

There are some fuzzy matches that are wrong. You can find them simply by searching the po file for the word fuzzy.

For example here: https://github.com/OpenGeoLabs/django-helpdesk/blob/9005f4c51974f1359700cfcf3c3fb1fa1fa5acea/helpdesk/locale/cs/LC_MESSAGES/django.po#L436

And here: https://github.com/OpenGeoLabs/django-helpdesk/blob/9005f4c51974f1359700cfcf3c3fb1fa1fa5acea/helpdesk/locale/cs/LC_MESSAGES/django.po#L546

But there are more of them...

@gwasser
Copy link
Member

gwasser commented Feb 3, 2019

Sorry about that! I thought I had read cz was the correct two letter code, my mistake. Use whatever is correct :-)

@timthelion
Copy link
Collaborator

cz is country, cs is language.

@gwasser
Copy link
Member

gwasser commented Feb 16, 2019

The updated translation was merged in #716 so I think it's safe to close this ticket now. Thank you!

@gwasser gwasser closed this as completed Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Proposed updates to the translations
Projects
None yet
Development

No branches or pull requests

3 participants