Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage documentation should have working code #397

Closed
nkuttler opened this issue Jan 31, 2022 · 7 comments
Closed

Usage documentation should have working code #397

nkuttler opened this issue Jan 31, 2022 · 7 comments

Comments

@nkuttler
Copy link

The form markup provided in the documentation doesn't work [1], working code is in the test project [2] though when modified.

[1] https://django-hijack.readthedocs.io/en/stable/#usage
[2]: https://github.com/django-hijack/django-hijack/blob/master/hijack/tests/test_app/templates/user_list.html

@nkuttler
Copy link
Author

Speaking of, the "Generic template filter" also seems incorrect as there is an middleware that needs to be loaded to get a similar functionality through request.user.is_hijacked.

@Mogost
Copy link
Member

Mogost commented Jan 31, 2022

@nkuttler
Copy link
Author

Oh, that's surprising! I was wondering why there is no version choice on readthedocs, is that intentional?

@Mogost
Copy link
Member

Mogost commented Jan 31, 2022

In fact, we got access from @philippeowagner to manage this project. But we still don't have access to this service to host new docs. So there's nothing we can do about it.

@codingjoe
Copy link
Collaborator

I tried reaching out to him again via email. I am afraid that's the best I can do 🤷

@Mogost
Copy link
Member

Mogost commented Jan 31, 2022

@codingjoe In case you try will be successful please ask for access to fix our release action as well. https://github.com/django-hijack/django-hijack/blob/5f073f124c3c531242164a6c74808dd360957466/.github/workflows/release.yml

@codingjoe
Copy link
Collaborator

I am thrilled to report that I successfully build a new docs version on RTD 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants