-
-
Notifications
You must be signed in to change notification settings - Fork 783
/
test_bulk_operations.py
620 lines (524 loc) · 23 KB
/
test_bulk_operations.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
from unittest import mock
import tablib
from core.models import Book, UUIDBook
from core.tests.utils import ignore_widget_deprecation_warning
from django.core.exceptions import ValidationError
from django.test import TestCase
from import_export import exceptions, fields, resources, widgets
from import_export.instance_loaders import ModelInstanceLoader
class BulkTest(TestCase):
def setUp(self):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
self.resource = _BookResource()
rows = [(i + 1, "book_name") for i in range(10)]
self.dataset = tablib.Dataset(*rows, headers=["id", "name"])
def init_update_test_data(self, model=Book):
[model.objects.create(name="book_name") for _ in range(10)]
self.assertEqual(10, model.objects.count())
rows = model.objects.all().values_list("id", "name")
updated_rows = [(r[0], "UPDATED") for r in rows]
self.dataset = tablib.Dataset(*updated_rows, headers=["id", "name"])
class BulkCreateTest(BulkTest):
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_does_not_call_object_save(self, mock_bulk_create):
with mock.patch("core.models.Book.save") as mock_obj_save:
self.resource.import_data(self.dataset)
mock_obj_save.assert_not_called()
mock_bulk_create.assert_called_with(mock.ANY, batch_size=None)
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_batch_size_of_5(self, mock_bulk_create):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = 5
resource = _BookResource()
result = resource.import_data(self.dataset)
self.assertEqual(2, mock_bulk_create.call_count)
mock_bulk_create.assert_called_with(mock.ANY, batch_size=5)
self.assertEqual(10, result.total_rows)
@mock.patch("core.models.UUIDBook.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_uuid_model(self, mock_bulk_create):
"""Test create of a Model which defines uuid not pk (issue #1274)"""
class _UUIDBookResource(resources.ModelResource):
class Meta:
model = UUIDBook
use_bulk = True
batch_size = 5
fields = (
"id",
"name",
)
resource = _UUIDBookResource()
result = resource.import_data(self.dataset)
self.assertEqual(2, mock_bulk_create.call_count)
mock_bulk_create.assert_called_with(mock.ANY, batch_size=5)
self.assertEqual(10, result.total_rows)
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_no_batch_size(self, mock_bulk_create):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = None
resource = _BookResource()
result = resource.import_data(self.dataset)
self.assertEqual(1, mock_bulk_create.call_count)
mock_bulk_create.assert_called_with(mock.ANY, batch_size=None)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["new"])
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_called_dry_run(self, mock_bulk_create):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = None
resource = _BookResource()
result = resource.import_data(self.dataset, dry_run=True)
self.assertEqual(1, mock_bulk_create.call_count)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["new"])
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_not_called_when_not_using_transactions(self, mock_bulk_create):
class _BookResource(resources.ModelResource):
def import_data(
self,
dataset,
dry_run=False,
raise_errors=False,
use_transactions=None,
collect_failed_rows=False,
**kwargs,
):
# override so that we can enforce not using_transactions
using_transactions = False
return self.import_data_inner(
dataset,
dry_run,
raise_errors,
using_transactions,
collect_failed_rows,
**kwargs,
)
class Meta:
model = Book
use_bulk = True
resource = _BookResource()
resource.import_data(self.dataset, dry_run=True)
mock_bulk_create.assert_not_called()
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_batch_size_of_4(self, mock_bulk_create):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = 4
resource = _BookResource()
result = resource.import_data(self.dataset)
self.assertEqual(3, mock_bulk_create.call_count)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["new"])
@ignore_widget_deprecation_warning
def test_no_changes_for_errors_if_use_transactions_enabled(self):
with mock.patch("import_export.results.Result.has_errors") as mock_has_errors:
mock_has_errors.return_val = True
self.resource.import_data(self.dataset)
self.assertEqual(0, Book.objects.count())
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_use_bulk_disabled(self, mock_bulk_create):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = False
resource = _BookResource()
result = resource.import_data(self.dataset)
mock_bulk_create.assert_not_called()
self.assertEqual(10, Book.objects.count())
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["new"])
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_bad_batch_size_value(self, mock_bulk_create):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = "a"
resource = _BookResource()
with self.assertRaises(ValueError):
resource.import_data(self.dataset)
mock_bulk_create.assert_not_called()
@mock.patch("core.models.Book.objects.bulk_create")
def test_bulk_create_negative_batch_size_value(self, mock_bulk_create):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = -1
resource = _BookResource()
with self.assertRaises(ValueError):
resource.import_data(self.dataset)
mock_bulk_create.assert_not_called()
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_oversized_batch_size_value(self, mock_bulk_create):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = 100
resource = _BookResource()
result = resource.import_data(self.dataset)
self.assertEqual(1, mock_bulk_create.call_count)
mock_bulk_create.assert_called_with(mock.ANY, batch_size=None)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["new"])
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_logs_exception(self, mock_bulk_create):
e = ValidationError("invalid field")
mock_bulk_create.side_effect = e
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = 100
resource = _BookResource()
with mock.patch("logging.Logger.debug") as mock_exception:
resource.import_data(self.dataset)
mock_exception.assert_called_with(e, exc_info=e)
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_raises_exception(self, mock_bulk_create):
mock_bulk_create.side_effect = ValidationError("invalid field")
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = 100
resource = _BookResource()
with self.assertRaises(exceptions.ImportError):
resource.import_data(self.dataset, raise_errors=True)
@mock.patch("core.models.Book.objects.bulk_create")
@ignore_widget_deprecation_warning
def test_bulk_create_exception_gathered_on_dry_run(self, mock_bulk_create):
mock_bulk_create.side_effect = ValidationError("invalid field")
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = 100
resource = _BookResource()
result = resource.import_data(self.dataset, dry_run=True, raise_errors=False)
self.assertTrue(result.has_errors())
@ignore_widget_deprecation_warning
def test_m2m_not_called_for_bulk(self):
mock_m2m_widget = mock.Mock(spec=widgets.ManyToManyWidget)
class BookM2MResource(resources.ModelResource):
categories = fields.Field(attribute="categories", widget=mock_m2m_widget)
class Meta:
model = Book
use_bulk = True
resource = BookM2MResource()
self.dataset.append_col(["Cat 1|Cat 2"] * 10, header="categories")
resource.import_data(self.dataset, raise_errors=True)
mock_m2m_widget.assert_not_called()
def test_force_init_instance(self):
class _BookResource(resources.ModelResource):
def get_instance(self, instance_loader, row):
raise AssertionError("should not be called")
class Meta:
model = Book
force_init_instance = True
resource = _BookResource()
self.assertIsNotNone(
resource.get_or_init_instance(
ModelInstanceLoader(resource), self.dataset[0]
)
)
@mock.patch("import_export.resources.atomic_if_using_transaction")
def test_no_sub_transaction_on_row_for_bulk(self, mock_atomic_if_using_transaction):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
resource = _BookResource()
resource.import_data(self.dataset)
self.assertIn(
False, [x[0][0] for x in mock_atomic_if_using_transaction.call_args_list]
)
class BulkUpdateTest(BulkTest):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
fields = ("id", "name")
import_id_fields = ("id",)
def setUp(self):
super().setUp()
self.init_update_test_data()
self.resource = self._BookResource()
@ignore_widget_deprecation_warning
def test_bulk_update(self):
result = self.resource.import_data(self.dataset)
[self.assertEqual("UPDATED", b.name) for b in Book.objects.all()]
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["update"])
@mock.patch("core.models.Book.objects.bulk_update")
@ignore_widget_deprecation_warning
def test_bulk_update_batch_size_of_4(self, mock_bulk_update):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = 4
resource = _BookResource()
result = resource.import_data(self.dataset)
self.assertEqual(3, mock_bulk_update.call_count)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["update"])
@mock.patch("core.models.Book.objects.bulk_update")
@ignore_widget_deprecation_warning
def test_bulk_update_batch_size_of_5(self, mock_bulk_update):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = 5
resource = _BookResource()
result = resource.import_data(self.dataset)
self.assertEqual(2, mock_bulk_update.call_count)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["update"])
@mock.patch("core.models.Book.objects.bulk_update")
@ignore_widget_deprecation_warning
def test_bulk_update_no_batch_size(self, mock_bulk_update):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
batch_size = None
resource = _BookResource()
result = resource.import_data(self.dataset)
self.assertEqual(1, mock_bulk_update.call_count)
mock_bulk_update.assert_called_with(mock.ANY, mock.ANY, batch_size=None)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["update"])
@mock.patch("core.models.Book.objects.bulk_update")
@ignore_widget_deprecation_warning
def test_bulk_update_not_called_when_not_using_transactions(self, mock_bulk_update):
class _BookResource(resources.ModelResource):
def import_data(
self,
dataset,
dry_run=False,
raise_errors=False,
use_transactions=None,
collect_failed_rows=False,
**kwargs,
):
# override so that we can enforce not using_transactions
using_transactions = False
return self.import_data_inner(
dataset,
dry_run,
raise_errors,
using_transactions,
collect_failed_rows,
**kwargs,
)
class Meta:
model = Book
use_bulk = True
resource = _BookResource()
resource.import_data(self.dataset, dry_run=True)
mock_bulk_update.assert_not_called()
@mock.patch("core.models.Book.objects.bulk_update")
@ignore_widget_deprecation_warning
def test_bulk_update_called_for_dry_run(self, mock_bulk_update):
self.resource.import_data(self.dataset, dry_run=True)
self.assertEqual(1, mock_bulk_update.call_count)
@mock.patch("core.models.Book.objects.bulk_update")
@ignore_widget_deprecation_warning
def test_bulk_not_called_when_use_bulk_disabled(self, mock_bulk_update):
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = False
resource = _BookResource()
result = resource.import_data(self.dataset)
self.assertEqual(10, Book.objects.count())
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["update"])
mock_bulk_update.assert_not_called()
@mock.patch("core.models.Book.objects.bulk_update")
@ignore_widget_deprecation_warning
def test_bulk_update_logs_exception(self, mock_bulk_update):
e = ValidationError("invalid field")
mock_bulk_update.side_effect = e
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
resource = _BookResource()
with mock.patch("logging.Logger.debug") as mock_exception:
resource.import_data(self.dataset)
mock_exception.assert_called_with(e, exc_info=e)
@mock.patch("core.models.Book.objects.bulk_update")
@ignore_widget_deprecation_warning
def test_bulk_update_raises_exception(self, mock_bulk_update):
e = ValidationError("invalid field")
mock_bulk_update.side_effect = e
class _BookResource(resources.ModelResource):
class Meta:
model = Book
use_bulk = True
resource = _BookResource()
with self.assertRaises(exceptions.ImportError) as raised_exc:
resource.import_data(self.dataset, raise_errors=True)
self.assertEqual(e, raised_exc)
class BulkUUIDBookUpdateTest(BulkTest):
def setUp(self):
super().setUp()
self.init_update_test_data(model=UUIDBook)
@mock.patch("core.models.UUIDBook.objects.bulk_update")
@ignore_widget_deprecation_warning
def test_bulk_update_uuid_model(self, mock_bulk_update):
"""Test update of a Model which defines uuid not pk (issue #1274)"""
class _UUIDBookResource(resources.ModelResource):
class Meta:
model = UUIDBook
use_bulk = True
batch_size = 5
fields = (
"id",
"name",
)
resource = _UUIDBookResource()
result = resource.import_data(self.dataset)
self.assertEqual(2, mock_bulk_update.call_count)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["update"])
class BulkDeleteTest(BulkTest):
class DeleteBookResource(resources.ModelResource):
def for_delete(self, row, instance):
return True
class Meta:
model = Book
use_bulk = True
# there are errors when diffing with mocks
# therefore disable diff with this flag
skip_diff = True
def setUp(self):
super().setUp()
self.resource = self.DeleteBookResource()
self.resource._meta.batch_size = 1000
self.resource._meta.use_bulk = True
self.init_update_test_data()
@mock.patch("core.models.Book.delete")
@ignore_widget_deprecation_warning
def test_bulk_delete_use_bulk_is_false(self, mock_obj_delete):
self.resource._meta.use_bulk = False
self.resource.import_data(self.dataset)
self.assertEqual(10, mock_obj_delete.call_count)
@mock.patch("core.models.Book.objects")
@ignore_widget_deprecation_warning
def test_bulk_delete_batch_size_of_4(self, mock_obj_manager):
self.resource._meta.batch_size = 4
result = self.resource.import_data(self.dataset)
self.assertEqual(3, mock_obj_manager.filter.return_value.delete.call_count)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["delete"])
@mock.patch("core.models.Book.objects")
@ignore_widget_deprecation_warning
def test_bulk_delete_batch_size_of_5(self, mock_obj_manager):
self.resource._meta.batch_size = 5
result = self.resource.import_data(self.dataset)
self.assertEqual(2, mock_obj_manager.filter.return_value.delete.call_count)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["delete"])
@mock.patch("core.models.Book.objects")
@ignore_widget_deprecation_warning
def test_bulk_delete_batch_size_is_none(self, mock_obj_manager):
self.resource._meta.batch_size = None
result = self.resource.import_data(self.dataset)
self.assertEqual(1, mock_obj_manager.filter.return_value.delete.call_count)
self.assertEqual(10, result.total_rows)
self.assertEqual(10, result.totals["delete"])
@mock.patch("core.models.Book.objects")
@ignore_widget_deprecation_warning
def test_bulk_delete_not_called_when_not_using_transactions(self, mock_obj_manager):
class _BookResource(self.DeleteBookResource):
def import_data(
self,
dataset,
dry_run=False,
raise_errors=False,
use_transactions=None,
collect_failed_rows=False,
**kwargs,
):
# override so that we can enforce not using_transactions
using_transactions = False
return self.import_data_inner(
dataset,
dry_run,
raise_errors,
using_transactions,
collect_failed_rows,
**kwargs,
)
resource = _BookResource()
resource.import_data(self.dataset, dry_run=True)
self.assertEqual(0, mock_obj_manager.filter.return_value.delete.call_count)
@mock.patch("core.models.Book.objects")
@ignore_widget_deprecation_warning
def test_bulk_delete_called_for_dry_run(self, mock_obj_manager):
self.resource.import_data(self.dataset, dry_run=True)
self.assertEqual(1, mock_obj_manager.filter.return_value.delete.call_count)
@mock.patch("core.models.Book.objects")
@ignore_widget_deprecation_warning
def test_bulk_delete_logs_exception(self, mock_obj_manager):
e = Exception("invalid")
mock_obj_manager.filter.return_value.delete.side_effect = e
with mock.patch("logging.Logger.debug") as mock_exception:
self.resource.import_data(self.dataset)
mock_exception.assert_called_with(e, exc_info=mock.ANY)
self.assertEqual(1, mock_exception.call_count)
@mock.patch("core.models.Book.objects")
@ignore_widget_deprecation_warning
def test_bulk_delete_raises_exception(self, mock_obj_manager):
e = Exception("invalid")
mock_obj_manager.filter.return_value.delete.side_effect = e
with self.assertRaises(Exception) as raised_exc:
self.resource.import_data(self.dataset, raise_errors=True)
self.assertEqual(e, raised_exc)
class BulkUUIDBookDeleteTest(BulkTest):
class DeleteBookResource(resources.ModelResource):
def for_delete(self, row, instance):
return True
class Meta:
model = UUIDBook
use_bulk = True
batch_size = 5
def setUp(self):
super().setUp()
self.resource = self.DeleteBookResource()
self.init_update_test_data(model=UUIDBook)
@ignore_widget_deprecation_warning
def test_bulk_delete_batch_size_of_5(self):
self.assertEqual(10, UUIDBook.objects.count())
self.resource.import_data(self.dataset)
self.assertEqual(0, UUIDBook.objects.count())