Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import_obj() declaration can be improved for consistency #1518

Closed
matthewhegarty opened this issue Dec 2, 2022 · 0 comments
Closed

import_obj() declaration can be improved for consistency #1518

matthewhegarty opened this issue Dec 2, 2022 · 0 comments
Assignees
@matthewhegarty
Labels
enhancement good first issue An issue for a first time contributor v4

Comments

@matthewhegarty
Copy link
Contributor

Throughout the code base, the param name row is used to define the incoming row (even though this could be JSON or YAML). In import_obj() it is named data, which is less descriptive. We should standardise variable naming for better readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewhegarty matthewhegarty

Labels
enhancement good first issue An issue for a first time contributor v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthewhegarty