Dry run not working with transactions is slow #488
Comments
arj03
changed the title
|
I have PR #480 already open to fix up transactionality with import_data that you might want to look at. |
|
Is this still an issue? |
|
Should be fixed with #480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It appears that when running with transactions enabled, the semantics of dry_run changes. This means that in preview mode it will potentially start doing all kinds of crazy database stuff, only to rollback the transaction in case the user doesn't confirm the changes. For our app with a rather complicated save, this makes preview 10 times slower than it should be.
The following patch reverts so that dry_run can be used with transactions as well:
arj03@528ca8f
I don't see why we can't both have transactions and dry_run, they should be orthogonal.
The text was updated successfully, but these errors were encountered: