Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for all versions of Django prior to 1.11 #681

Closed
bmihelac opened this issue Nov 23, 2017 · 7 comments
Closed

Drop support for all versions of Django prior to 1.11 #681

bmihelac opened this issue Nov 23, 2017 · 7 comments
Labels
stale Stale bot

Comments

@bmihelac
Copy link
Member

As stated on Django 2.0 release notes I propose this change in next major/breaking version.

Following the release of Django 2.0, we suggest that third-party app authors drop support for all versions of Django prior to 1.11. At that time, you should be able to run your package’s tests using python -Wd so that deprecation warnings do appear. After making the deprecation warning fixes, your app should be compatible with Django 2.0.

@mgrdcm
Copy link
Contributor

mgrdcm commented Nov 23, 2017

How about doing it gradually by dropping support for <1.8 first (which is an LTS release) as the next breaking change and then dropping <1.11 in the next one?

@shaggyfrog
Copy link
Contributor

shaggyfrog commented Nov 24, 2017 via email

@mgrdcm
Copy link
Contributor

mgrdcm commented Nov 24, 2017

For some reason I thought 2.0 wasn't going to be released until July. I see now that luckily I'm wrong (it's scheduled for December 2017 if anyone else is wondering :).

I think it's weird for Django to recommend to (and for apps to) drop support for the 1.8 LTS since it'll be supported by Django until April 2018.

@mgrdcm
Copy link
Contributor

mgrdcm commented Nov 24, 2017

Also a little looking at the django-import-export code, I see around a dozen places where conditionals and workarounds could go away by not supporting <1.8 but other than #680 I haven't seen anything that would be saved by only supporting >=1.11.

@bmihelac
Copy link
Member Author

make sense to support 1.8 LTS until it is officialy supported (at least april, 2018 according to django docs)

@mgrdcm
Copy link
Contributor

mgrdcm commented Nov 24, 2017

I created #685 as a start to removing support for Django<1.8.

@stale
Copy link

stale bot commented Feb 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale bot label Feb 11, 2019
@stale stale bot closed this as completed Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale bot
Projects
None yet
Development

No branches or pull requests

3 participants