Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tests using runtests.sh #1686

Closed
cocorocho opened this issue Nov 21, 2023 · 1 comment
Closed

Running tests using runtests.sh #1686

cocorocho opened this issue Nov 21, 2023 · 1 comment

Comments

@cocorocho
Copy link
Contributor

I can't seem to find where runtest.sh is used but the file still uses docker-compose instead of docker compose which is the old V1 syntax.

docker-compose -f tests/docker-compose.yml up -d

Is this test runner still to be used? If so maybe I could create a PR for using the valid docker[-]compose syntax based on whichever is available

@matthewhegarty
Copy link
Contributor

matthewhegarty commented Nov 21, 2023

Hi
The purpose of runtests.sh is for those that want to run a full test suite locally (docs). You'd be welcome to submit a PR to update to latest syntax. I don't think there's any need to preserve backwards compatibility, but you could put it into the v4 branch if you wish (release-4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants