Column names with spaces

[pwr905]

Can't use column names with spaces - at least, as far as I could tell.

If this is indeed the case, and I'm not just being stupid, the fix is in resources.py at line 299.

    method = getattr(self, 'dehydrate_%s' % field.column_name, None)

becomes

    method = getattr(self, 'dehydrate_%s' % field.column_name.replace(' ', '_'), None)

Current use cases should be unaffected by that change.

[bmihelac]

Hi, it looks like we should use attribute_name instead of column_name. attribute_name:

method = getattr(self, 'dehydrate_%s' % field.column_name, None)

I have to test this, but would appreciate if you can test that this work for your case.

regards

[pwr905]

That was my initial thought, too, but attribute_name might be blank, and that led me down the road of testing for a value. Given that I wasn't too familiar with the internals of import_export, the replace seemed an easier fix at the time.

Also, the use case for me is generating an export report (of sorts) for non-technical users, and being able to specify the column name in a very verbose way (i.e. more descriptive than what I name my attributes) is a requirement.

[bmihelac]

@pwr905 I am almost sure that attribute_name should be used in dehydratebut I will have catch some time to dig in code and test it does not break anything.

[bmihelac]

In https://github.com/bmihelac/django-import-export/compare/fix-36-use-field-name-for-dehydration branch is a change that uses field_name for dehydrating fields.

field_name is assigned when Resource is declared.

Example of use is in tests:

https://github.com/bmihelac/django-import-export/blob/d73c05641eafe52d7904ec0c53737ce195795a00/tests/core/tests/resources_tests.py#L181

Does this solve issue stated above?

[pwr905]

Sorry for the delay, been really busy. Will test it out in the next few days and let you know.