Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaStorage does not respect the read_mode parameter #416

Closed
jbradberry opened this issue Feb 29, 2016 · 5 comments
Closed

MediaStorage does not respect the read_mode parameter #416

jbradberry opened this issue Feb 29, 2016 · 5 comments

Comments

@jbradberry
Copy link
Contributor

Which is a problem if one needs to deal with files by using universal newlines mode, for example.

@bmihelac
Copy link
Member

bmihelac commented Mar 2, 2016

Thanks for reporting. Would you like to submit a PR?

@jbradberry
Copy link
Contributor Author

I started on one, but found that the obvious change broke tests elsewhere.

@bmihelac
Copy link
Member

bmihelac commented Mar 2, 2016

That is really frustrating :( If you open PR with broken tests I would be glad to take a look and fix tests in the next days.

@jbradberry
Copy link
Contributor Author

It appears that I misremembered, the broken test I was seeing (core.tests.base_formats_tests.CSVTest.test_import_unicode) happens on my system regardless of whether I've made changes or not.

@bmihelac
Copy link
Member

bmihelac commented Mar 3, 2016

Merged, thanks a lot! Would you be kind to open an issue with stacktrace for broken tests with python and tablib versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants