Fix __truediv__ if result is Decimal #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @niklasb ! Thank you for contributing! I will take a look during the day - failing tests are related to the latest changes in Django and I will fix them separately. |
|
Hello @Stranger6667, Did you fix the falling tests on django 3.2? |
|
Hi @Zagrebelin ! Not yet, but thanks for the proposal! :) |
Stranger6667
force-pushed
the
fix-truediv
branch
from
199411c
to
81a595c
Compare
|
Thank you for your contribution! |
|
Released in 1.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__truediv__can return a decimal, in which case decimal_places cannot be set.See #522 (comment)