correct copy of attributes #629
Conversation
tned73
force-pushed
the
feature/correct_copy_attributes
branch
2 times, most recently
from
48a0f7b
to
5b48c6a
Compare
tned73
force-pushed
the
feature/correct_copy_attributes
branch
from
5b48c6a
to
58885ea
Compare
tests/test_money.py
Outdated
| assert one._decimal_places_display is None, "this should be None" | ||
| assert one.decimal_places == 2 |
There was a problem hiding this comment.
Generally, I'd prefer a bit higher level assertions (at least in new tests) - e.g. how values will be formatted, as these attributes are telling more about implementation details.
tests/test_money.py
Outdated
| assert three.decimal_places == 2 | ||
|
|
||
|
|
||
| def test_add_copy_display_places(): |
There was a problem hiding this comment.
Also, it will be nice to use pytest.mark.parametrize as these 3 tests have similar structure
|
Thanks for working on this! |
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 29 29
Lines 971 973 +2
Branches 164 165 +1
=======================================
+ Hits 951 953 +2
Misses 13 13
Partials 7 7
Continue to review full report at Codecov.
|
|
you are welkom, I have changed the tests as best I can. Let me know if it can be better. |
tned73
force-pushed
the
feature/correct_copy_attributes
branch
from
c57f3e4
to
f6fd044
Compare
|
Released in 2.0.2 |
After an action like adding the attribute decimal_places_display was incorrectly set and it was interfering with formatting in the str. Even the deprecation warning was triggered.
This fix only copy the internal attributes and avoids incorrectly setting them.
Small proof of issue (Version 2.0.1) Also notice formatting problem.