Update rates from fixer.io #675 #681
Conversation
| @@ -45,9 +45,12 @@ def get_params(self): | |||
| return {} | |||
|
|
|||
| def get_response(self, **params): | |||
| url = self.get_url(**params) | |||
| headers = { | |||
| "User-Agent": "Mozilla/5.0", | |||
There was a problem hiding this comment.
You could get into trouble for faking the User-Agent, not sure. But I'll leave that up to others to scrutinize :)
| @@ -15,4 +15,4 @@ def __init__(self, url=settings.FIXER_URL, access_key=settings.FIXER_ACCESS_KEY) | |||
| self.access_key = access_key | |||
|
|
|||
| def get_params(self): | |||
| return {"access_key": self.access_key} | |||
| return {"apikey": self.access_key} | |||
There was a problem hiding this comment.
Why is this change added? Isn't the fixer api expecting an access_key parameter?
https://fixer.io/documentation
There was a problem hiding this comment.
Hello Ignat! Since fixer.io does not provide its API through the endpoints described in the documentation, but instead uses APILayer services for this purpose, it was necessary to change the key specifically for APILayer. This is described in the API documentation.
There was a problem hiding this comment.
Thanks @spaut33 for the quick response. It makes sense, but isn't the apikey suppose to be included in the headers in that case?
Sorry for the questions but a code I'm working on started failing after upgrading djmoney to 3.1.0 and I'm trying to figure out what's the issue.
There was a problem hiding this comment.
It works both ways, as a request parameter and as a header. However, I believe that APILayer may not be following the correct convention, as custom fields in headers should start with the "X-" prefix.
There was a problem hiding this comment.
Same here. Fixed by creating API key through ApiLayer and adding FIXER_URL = "https://api.apilayer.com/fixer/latest" to my settings.py
There was a problem hiding this comment.
But apilayer seems unreliable — getting timeouts accessing the API. Could we maybe send access_key and apikey params to suit both APIs?
There was a problem hiding this comment.
Thanks @fedosov. I've just added the FIXER_URL to the settings.py as well. It took me some time to figure that out. Maybe the default should be updated.
There was a problem hiding this comment.
I made a PR so it can work with both APIs
#707
Small fix for #675. Changed get parameter and added 'user-agent' header to avoid 403 error.