Use unicode_literals future import #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Smells safe to me, but can you add the encoding to the files you've changed as well? # coding: utf-8
from future import unicode_literalsSome context: http://stackoverflow.com/a/826710/10612 |
|
@jwhitlock: Ah, good thought. Fixed! |
singingwolfboy
force-pushed
the
unicode_literals
branch
from
06c0f50
to
4bc6ec9
Compare
jwhitlock
added a commit
that referenced
this pull request
Jun 26, 2015
Support unicode in filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem where
runner.pywas trying to print a filename that had unicode characters in the name of the file, and it ran into trouble. This should fix it.