Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Django transaction management for issue #226 #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akuchling
Copy link

I wanted to try the FastFixtureTestRunner, but found it didn't work with Django 1.8. I looked at the transaction-management features in Django 1.5 vs. 1.8 and came up with this set of changes.

This patch works well enough that my test suite of 255 tests ran successfully using FastFixtureTestRunner, but my testing wasn't exhaustive: for example, I didn't check that any fixture changes are rolled back as expected.

@coveralls
Copy link

coveralls commented Nov 11, 2016

Coverage Status

Coverage increased (+0.5%) to 68.845% when pulling 8e0b823 on akuchling:master into 3b9dad7 on django-nose:master.

@jwhitlock
Copy link
Contributor

I'm inclined to merge this because it works for you, but there are still no tests in the django-nose test suite that exercise FastFixtureTestRunner, so I'm not sure if it even works in Django 1.9, 1.10, etc.

@jwhitlock
Copy link
Contributor

Maybe the tests can be imported from #258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants