Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to apply custom benefit #2163

Closed
arunjoseph opened this issue Nov 10, 2016 · 2 comments
Closed

Not able to apply custom benefit #2163

arunjoseph opened this issue Nov 10, 2016 · 2 comments
Labels

Comments

@arunjoseph
Copy link

arunjoseph commented Nov 10, 2016

I followed the following http://django-oscar.readthedocs.io/en/releases-1.2/howto/how_to_create_a_custom_benefit.html I did the same and tried to apply the benefit using create_benefit present in the oscar.apps.offer.custom after appling I get a recursion error and the function also warns of recursion error if not applied __str__ but even after that I am facing the same problem. Kindly help ASAP

I am using Oscar 1.3

@mredvard
Copy link

I solved it by adding my own
@Property
def name(): and
@Property
def description()

@sasha0
Copy link
Member

sasha0 commented Dec 5, 2017

I believe we should leave a note in the docs about name property declaration when defining custom benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants