New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor communications #2591
Closed
sasha0
wants to merge
35
commits into
django-oscar:master
from
metaclassco:issues/319/communications
Closed
Refactor communications #2591
sasha0
wants to merge
35
commits into
django-oscar:master
from
metaclassco:issues/319/communications
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2591 +/- ##
==========================================
- Coverage 84.62% 84.54% -0.09%
==========================================
Files 279 286 +7
Lines 15045 15135 +90
==========================================
+ Hits 12732 12796 +64
- Misses 2313 2339 +26
|
samitnuk
force-pushed
the
issues/319/communications
branch
from
February 7, 2018 13:42
5dceafc
to
1c7d40c
Compare
sasha0
force-pushed
the
issues/319/communications
branch
3 times, most recently
from
February 20, 2018 13:20
4827fb5
to
94e3385
Compare
samitnuk
force-pushed
the
issues/319/communications
branch
2 times, most recently
from
February 22, 2018 19:37
20a9b91
to
ffa9bc0
Compare
samitnuk
force-pushed
the
issues/319/communications
branch
15 times, most recently
from
August 29, 2018 18:56
1fad3e7
to
7b00c5a
Compare
This change needed since `ProductAlert` model does not moved to `communication` app.
samitnuk
force-pushed
the
issues/319/communications
branch
2 times, most recently
from
December 8, 2019 10:38
a7d83a9
to
d8097b3
Compare
samitnuk
force-pushed
the
issues/319/communications
branch
from
December 8, 2019 10:56
d8097b3
to
192b9f4
Compare
@solarissmoke Many thanks! This PR updated based on your comments. Please review when you will have a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #319 #783
Summary:
communication
.Dispatcher
moved tocommunication
app's utils.Dispatcher
improved with methods to send each separate email.Dispatcher
.communication
app as well.OSCAR_SAVE_SENT_EMAILS_TO_DB
,True
by default).customer
app tocommunication
app (with data migrations) -CommunicationEventType
,Email
andNotification
.MOVED_CLASSES
andMOVED_MODELS
.TestOrderPlacementMixin
- Now we useDispatcher
to send emails and code (event code) does not used when we get message context for email that informs about a placed order.commtype_*
) moved fromcustomer/emails
tocommunication/emails
.customer/email/*.html
andcustomer/notification/*.html
moved tocommunication/email/*.html
andcommunication/notification/*.html
.