Skip to content

Commit

Permalink
Merge pull request #457 from yakky/bugfix/issue-424-gettext
Browse files Browse the repository at this point in the history
Replace ugettext with gettext to fix deprecation warnings
  • Loading branch information
chrisglass committed Aug 18, 2020
2 parents 1d719a0 + 49c2abf commit 8f12362
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion polymorphic/admin/childadmin.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from django.contrib import admin
from django.urls import resolve
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from polymorphic.utils import get_base_polymorphic_model

Expand Down
2 changes: 1 addition & 1 deletion polymorphic/admin/filters.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from django.contrib import admin
from django.core.exceptions import PermissionDenied
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _


class PolymorphicChildModelFilter(admin.SimpleListFilter):
Expand Down
2 changes: 1 addition & 1 deletion polymorphic/admin/forms.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from django import forms
from django.contrib.admin.widgets import AdminRadioSelect
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _


class PolymorphicModelChoiceForm(forms.Form):
Expand Down
6 changes: 3 additions & 3 deletions polymorphic/admin/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from django.contrib.admin.helpers import AdminField, InlineAdminForm, InlineAdminFormSet
from django.utils.encoding import force_text
from django.utils.text import capfirst
from django.utils.translation import ugettext
from django.utils.translation import gettext

from polymorphic.formsets import BasePolymorphicModelFormSet

Expand Down Expand Up @@ -96,7 +96,7 @@ def inline_formset_data(self):
"name": "#%s" % self.formset.prefix,
"options": {
"prefix": self.formset.prefix,
"addText": ugettext("Add another %(verbose_name)s")
"addText": gettext("Add another %(verbose_name)s")
% {"verbose_name": capfirst(verbose_name)},
"childTypes": [
{
Expand All @@ -105,7 +105,7 @@ def inline_formset_data(self):
}
for model in self.formset.child_forms.keys()
],
"deleteText": ugettext("Remove"),
"deleteText": gettext("Remove"),
},
}
)
Expand Down
2 changes: 1 addition & 1 deletion polymorphic/admin/parentadmin.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from django.utils.encoding import force_text
from django.utils.http import urlencode
from django.utils.safestring import mark_safe
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from polymorphic.utils import get_base_polymorphic_model

Expand Down
6 changes: 3 additions & 3 deletions polymorphic/templatetags/polymorphic_formset_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from django.template import Library
from django.utils.encoding import force_text
from django.utils.text import capfirst
from django.utils.translation import ugettext
from django.utils.translation import gettext

from polymorphic.formsets import BasePolymorphicModelFormSet

Expand Down Expand Up @@ -44,10 +44,10 @@ def as_script_options(formset):
"prefix": formset.prefix,
"pkFieldName": formset.model._meta.pk.name,
"addText": getattr(formset, "add_text", None)
or ugettext("Add another %(verbose_name)s")
or gettext("Add another %(verbose_name)s")
% {"verbose_name": capfirst(verbose_name)},
"showAddButton": getattr(formset, "show_add_button", True),
"deleteText": ugettext("Delete"),
"deleteText": gettext("Delete"),
}

if isinstance(formset, BasePolymorphicModelFormSet):
Expand Down

0 comments on commit 8f12362

Please sign in to comment.