Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flamegraph Display #1

Merged
merged 3 commits into from Jan 3, 2020
Merged

Flamegraph Display #1

merged 3 commits into from Jan 3, 2020

Conversation

glynn-zenefits
Copy link
Collaborator

127 0 0 1_8000_django_query_profiler_1b3e059ddedb40278aeb29816769ddc6_QUERY_SIGNATURE_name=food_order

Uses d3 flame-graph, you can click to "zoom" etc.

(Note ported from same feature added to Zenefits internal tool, there's some small handling here for "multiple roots" which maybe can't happen with the open-source version (i.e. middleware vs view for the same request UUID.)

@glynn-zenefits
Copy link
Collaborator Author

Here's an example of what it looks like in the "degenerate" case i.e. one of Zenefits' APIs with a lot more SQL than the sample app creates:

Screen Shot 2020-01-02 at 5 46 05 PM

@django-query-profiler
Copy link
Owner

django-query-profiler commented Jan 3, 2020

Codecov Report

Merging #1 into master will decrease coverage by 4.1%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   94.03%   89.93%   -4.11%     
==========================================
  Files          17       17              
  Lines         453      477      +24     
==========================================
+ Hits          426      429       +3     
- Misses         27       48      +21
Impacted Files Coverage Δ
...ango_query_profiler/chrome_plugin_helpers/views.py 72.72% <100%> (+2.72%) ⬆️
..._query_profiler/query_profiler_storage/__init__.py 82.46% <8.69%> (-12.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e013d0...c2d1f85. Read the comment docs.

Copy link
Owner

@django-query-profiler django-query-profiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing!

@django-query-profiler django-query-profiler merged commit 7b3e6ba into master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants