Fixing master with latest changes for dependent packages #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yashmaheshwari
commented
Nov 22, 2020
•
yashmaheshwari
commented
- Was getting some package incompatibility error for mo-future
- We are not using the package directly
- Maybe it means we should have a requirements.txt file ?
- Figured out the version used by running pip freeze
- Added fix for djangotip
- Fixed for flake8
- Was getting some package incompatibility error for mo-future - We are not using the package directly - Maybe it means we should have a requirements.txt file ? - Figured out the version used by running pip freeze
yashmaheshwari
force-pushed
the
yash/fixing_pip_install_setup
branch
from
474e8bc
to
bd276de
Compare
- Would look into djangottip in a later PR
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 98.73% 98.75% +0.01%
==========================================
Files 16 17 +1
Lines 474 480 +6
==========================================
+ Hits 468 474 +6
Misses 6 6
Continue to review full report at Codecov.
|
- Looks like this was always wrong, but django was not enforcing it before
- Including tests folder in flake8 since it was complaining - Had to fix some flake8 issues after including tests
yashmaheshwari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.