updating Recurrence class to be py3 compatible #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in python 3 the __str__ method is called when converting a class to a string (opposed to the __unicode__ method in py2). This change renames the __unicode__ method to __str__, so we can easily get the serialized version of a Recurrence object and while doing so maintain py2 compatibility be wrapping the class with Djangos python_2_unicode_compatible decorator for more info see https://docs.djangoproject.com/en/1.11/topics/python3/#str-and-unicode-methods
|
This looks good to me - thanks @ericbuckley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in python 3 the
__str__method is called when converting a class to astring (opposed to the
__unicode__method in py2). This change renamesthe
__unicode__method to__str__, so we can easily get the serializedversion of a Recurrence object and while doing so maintain py2
compatibility be wrapping the class with Django's
python_2_unicode_compatibledecoratorfor more info see https://docs.djangoproject.com/en/1.11/topics/python3/#str-and-unicode-methods