New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #87 #137
Fixes #87 #137
Conversation
…ationObserver Fixes issue when buttons stop working if new inline has been added dynamically.
This looks good to me - just two comments:
Thanks for your efforts on this - they're much appreciated! |
Cool!
|
Fantastic - thanks @pasevin! All going well I'll test this and merge it tonight. |
Hi @pasevin - I can't get this to work locally - |
My bad! It's a native django-grappelli class name. I will fix it asap. I knew I will screw this up in some way :)) |
Should be working now. I checked on the vanilla Django theme. |
Awesome - thanks @pasevin. I'll take another look as soon as I can (hopefully by the end of the week). |
I am trying to use this package for my recurrence. recurrence-widget.init.js:7 Uncaught TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'. The node with the id "container" is no where to find. Just a note: I am using version 1.9 as I am still on Python 2.7 and django 1.11 |
i get the same |
This is my attempt at fixing this long-standing issue. It works for my needs without issues so far.
I've utilized MutationObserver for observing DOM node additions. And replaced Django render method with a javascript initialization instead.