Passing a null value to RecurrenceField will cause a TypeError

[audiolion]

At this point in the code https://github.com/django-recurrence/django-recurrence/blob/master/recurrence/forms.py#L147 if the value you passed is None it will throw a TypeError, saying it expected a string or a buffer. Maybe a check should be done, if value is None then value = '' the empty string

[dominicrodger]

How do you pass None to a form from the browser? Or are you using a form programmatically?

[audiolion]

I found it during testing yes so the form data was being generated and passed programmatically, I basically added recurrence: '' to the POST.data to fix it, but I expected if I didn't pass the field name to the form post data it wouldn't crash. I wasn't doing recurrence: None in the post data, I didn't include it at all. (The RecurrenceField is called recurrence on my model) So the form cleaning that was done assigns a value of None to the field if it is not present.

[dominicrodger]

Ah, OK - that makes sense, thanks @audiolion.

Pull requests to fix this welcome - especially if they contain tests!

[audiolion]

Ok might be a few days but I will send in a patch

[dominicrodger]

Sounds good - thanks! No pressure on getting it done, it doesn't sound like it would hit most users of django-recurrence. Don't worry if you can't get tests for it - I'll happily add them to a patch if needed.

[pytrumpeter]

Did this ever get patched? I'm running into this issue now. Thanks.

Edit: I monkey-patched it for now, so no rush. I returned None if a TypeError was thrown in the try/catch, seems to work okay for now, as my Recurrence field is not required.

[dominicrodger]

@harveynr - no, I don't think this was ever patched.

[dominicrodger]

Fixed by #122.