Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved MySQL support #167

Merged
merged 2 commits into from Mar 14, 2017
Merged

Improved MySQL support #167

merged 2 commits into from Mar 14, 2017

Conversation

smaccona
Copy link
Collaborator

Adds support for utf8 and utf8mb4 character sets in MySQL's default
configuration.

Closes #38.

Adds support for `utf8` and `utf8mb4` character sets in MySQL's default
configuration.

Closes #38.
@smaccona
Copy link
Collaborator Author

@avelis if you can review when you get a chance. Here are the 3 scenarios I tested for locally:

  • Fresh install: works
  • Upgrade over existing install on proper MySQL configuration with long index support: works, does not change underlying fields (they stay at width 300)
  • Upgrade over modified install on MySQL with no long index support (user manually changed the field width or created a truncated index and faked the initial migration): works, does not change underlying field (they stay at whatever width the user had them)

@avelis avelis merged commit d7ebda5 into jazzband:master Mar 14, 2017
@avelis
Copy link
Collaborator

avelis commented Mar 14, 2017

@smaccona Thanks again for working on this PR and long standing issue. Much appreciation from me.

I am planning a release with a major version bump. I will make sure to set the expectation this will break current installations. However, the upgrade scenario's you noted might work for others and I will highlight them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants