Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use unittest.mock instead of mock #1635

Closed
pgajdos opened this issue May 11, 2022 · 3 comments
Closed

use unittest.mock instead of mock #1635

pgajdos opened this issue May 11, 2022 · 3 comments
Labels
easy_to_fix

Comments

@pgajdos
Copy link

pgajdos commented May 11, 2022

Could you please consider to use built-in unittest.mock instead of mock, as a fallback at least?

https://trello.com/c/S6eADbii/64-remove-python-mock
https://fedoraproject.org/wiki/Changes/DeprecatePythonMock
@georgedorn
Copy link
Contributor

We dropped support for python 2 a while back, just never switched to unittest.mock out of inertia. I'd be happy to accept a PR for it, or I'll get to it myself eventually.

@ryanneilyoung
Copy link
Contributor

I've done the work in this PR: #1636

@georgedorn
Copy link
Contributor

Done quite a while ago and definitely released in v0.14.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy_to_fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@georgedorn @pgajdos @ryanneilyoung