New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python typing #1665
Comments
No offense, but the reality is that you probably shouldn't be starting new projects with Tastypie. IMO if you are embarking on new development with this library, you're eventually going to be disappointed. Practically speaking, this package is more in "maintenance mode" rather than any kind of active development. |
Thank you for your offensive response. Python typing doesn't exists because of noobs and people who starting with their development experience with Python. Practically speaking adding typing is a more maintenance task then new development |
Assuming we are talking about type hinting, a la mypy, I see no objections to implementing it. That said, I don't have the time or bandwidth to do it myself. I am happy to review and merge such an effort if somebody else wants to take this up, though. Adding a build step to validate the types would also be beneficial, uncover previously hidden bugs and prevent some kinds of regressions. I'd be fine with either inline or a PEP-484-style external project like django-stubs; the latter approach might be easier to do as an incremental effort. If somebody builds that, I'm happy to add it to tastypie's CI pipeline. As for whether tastypie is in active development, I don't see how that relates to whether it is likely to cause disappointment. Sometimes a project just does what it needs to do and doesn't need to expand in features until it reads email. |
Please, consider to add types for whole API. There's no room to guess what is what during development.
I don't see any real reason to support unsupported python versions to introduce typing system, which has been introduced in Python 3.5 and was actively developed ever since and which is supported by various tools like IDE, static checkers and more
The text was updated successfully, but these errors were encountered: