Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Allow header for 405s #691

Open
OddBloke opened this issue Oct 11, 2012 · 4 comments
Open

Include Allow header for 405s #691

OddBloke opened this issue Oct 11, 2012 · 4 comments

Comments

@OddBloke
Copy link

The method specified in the Request-Line is not allowed for the resource identified by the Request-URI. The response MUST include an Allow header containing a list of valid methods for the requested resource.
[http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.6]

@ondrowan
Copy link
Contributor

This is already implemented.

@bohde
Copy link
Contributor

bohde commented Oct 12, 2012

There are two places this doesn't happen:

I'm not quite sure what to do in those cases. I don't think 405 is the appropriate code, since it's based upon the content.

@ondrowan
Copy link
Contributor

Why is there check for put and delete anyway? It seems to be inconsistent as:

  • there is missing check for post
  • there are no additional checks in patch_detail
  • there has been already check if patch is allowed, so why additional put / delete checks?

Or am I missing anything?

@bohde
Copy link
Contributor

bohde commented Oct 12, 2012

patch_list is a bulk operation for multiple put_detail, and delete_detail. Because patch_list can be allowed while disallowing one of either, put_detail or delete_detail need to be verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants