Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IP/subnet to flags #37

Open
jsocol opened this issue Jun 14, 2012 · 2 comments
Open

Add IP/subnet to flags #37

jsocol opened this issue Jun 14, 2012 · 2 comments
Labels
pinned semver:minor
Milestone
1.0 - 0.1

Comments

@jsocol
Copy link
Collaborator

jsocol commented Jun 14, 2012

It would be valuable to turn on flags by internal IP or subnet. A comma-separated list of IP addresses with wild cards would be great.
@ghost ghost assigned jsocol Jun 14, 2012
@jsocol jsocol modified the milestones: 0.11, 0.12 Oct 27, 2014
@jsocol jsocol mentioned this issue Dec 4, 2015
Closed
@jsocol jsocol removed their assignment May 30, 2016
@jsocol jsocol added the pinned label Aug 26, 2017
@adamhaney
Copy link
Contributor

adamhaney commented Mar 13, 2019 •
edited

I currently have a need to be able to enable/disable flags by IP/subnet as well as the logic NOT of an IP/subnet and would be interested in contributing this. Does anyone have any strong opinions on API/design and/or would project maintainers be open to merging such functionality if I were to write it? This is probably a question best answered by @clintonb.

@adamhaney adamhaney mentioned this issue Mar 13, 2019
Closed
4 tasks
@clintonb
Copy link
Collaborator

@adamhaney sorry for the delay. I have no strong opinions. I'll provide feedback on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pinned semver:minor
Projects
None yet
Milestone
1.0 - 0.1
Development

No branches or pull requests
3 participants
@jsocol @clintonb @adamhaney