Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cache #36

Merged
merged 4 commits into from
Jun 16, 2017
Merged

Clear cache #36

merged 4 commits into from
Jun 16, 2017

Conversation

benjaoming
Copy link
Member

This should fix #34 by always clearing the cache when something is created (or deleted). In this case, the rollback doesn't AFAIK trigger the post_delete signal, but during tests, the post_save signal should be triggered to clear the cache.

It could also prevent other sorts of odd problems!

@codecov-io
Copy link

codecov-io commented Jun 16, 2017

Codecov Report

Merging #36 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage      76%   76.11%   +0.11%     
==========================================
  Files          25       25              
  Lines         600      603       +3     
==========================================
+ Hits          456      459       +3     
  Misses        144      144
Impacted Files Coverage Δ
django_nyt/models.py 85.38% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de7b9c3...17bcaec. Read the comment docs.

@benjaoming benjaoming merged commit 80f5965 into master Jun 16, 2017
@benjaoming benjaoming deleted the clear-cache branch June 16, 2017 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_notification_type_cache on NotificationType seems to cause errors with tests
2 participants