Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pyproject.toml, replace setup.cfg and setup.py #1199

Closed
benjaoming opened this issue Jul 18, 2022 · 1 comment · Fixed by #1227
Closed

Use pyproject.toml, replace setup.cfg and setup.py #1199

benjaoming opened this issue Jul 18, 2022 · 1 comment · Fixed by #1227
Assignees
@oscarmcm
Labels
easy-pickings A great beginner issue or project enhancement A feature request: Will be implemented if someone steps up!

Comments

@benjaoming
Copy link
Member

This project can use https://github.com/pypa/build

We should migrate all logic from setup.cfg and setup.py to pyproject.toml.

  • The release command in Makefile should be updated.
  • Instead of from wiki import __version__, we need to hard-code the version string in pyproject.toml

Nice-to-have:

  • A tool to bump versions
@oscarmcm oscarmcm self-assigned this Nov 16, 2022
@oscarmcm oscarmcm added enhancement A feature request: Will be implemented if someone steps up! easy-pickings A great beginner issue or project labels Nov 16, 2022
@oscarmcm
Copy link
Member

Discussion for this issue is happening at #1226

@oscarmcm oscarmcm mentioned this issue Nov 18, 2022
Merged
19 tasks
@oscarmcm oscarmcm linked a pull request Nov 18, 2022 that will close this issue
Add support for use pyproject.toml #1227
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscarmcm oscarmcm

Labels
easy-pickings A great beginner issue or project enhancement A feature request: Will be implemented if someone steps up!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for use pyproject.toml django-wiki/django-wiki
2 participants
@benjaoming @oscarmcm