Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environments for py3.11 and dj4.1 #1265

Merged
merged 4 commits into from Jan 31, 2023
Merged

Add environments for py3.11 and dj4.1 #1265

merged 4 commits into from Jan 31, 2023

Conversation

oscarmcm
Copy link
Member

Since support for Python 3.11 was finally added in #1234, this is a continuation of the work and finally have a new version that supports Python 3.11 (#1243, #1232)

@oscarmcm oscarmcm added the enhancement A feature request: Will be implemented if someone steps up! label Jan 30, 2023
@oscarmcm oscarmcm self-assigned this Jan 30, 2023
@oscarmcm
Copy link
Member Author

It seems that we have an issue in the Circle CI

Starting container circleci/python:3.11
Warning: No authentication provided, using CircleCI credentials for pulls from Docker Hub.
  image cache not found on this host, downloading circleci/python:3.11

Error response from daemon: manifest for circleci/python:3.11 not found: manifest unknown: manifest unknown

@benjaoming
Copy link
Member

Oh hmm, haven't read about the various flavors of images. Sounds like the circleci image isn't being maintained.

Try with image: cimg/python:<<parameters.python_version>> instead of image: circleci/python:<<parameters.python_version>> ?

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1265 (0153f76) into main (7bca6fa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1265   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files         109      109           
  Lines        4657     4657           
  Branches      531      619   +88     
=======================================
  Hits         3688     3688           
  Misses        761      761           
  Partials      208      208           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oscarmcm
Copy link
Member Author

@benjaoming thanks for the image change proposal 💯

This is ready to be merged!

Copy link
Member

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@benjaoming benjaoming merged commit 433a9ab into main Jan 31, 2023
@benjaoming benjaoming deleted the py311_support branch January 31, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request: Will be implemented if someone steps up!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants