Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html whitelist bugfix #1314

Merged
merged 10 commits into from Oct 6, 2023
Merged

Conversation

orcephrye
Copy link
Contributor

The setting WIKI_MARKDOWN_HTML_WHITELIST is not pulled into MARKDOWN_HTML_WHITELIST. A Union is performed, but the returning value is thrown away.

See:

MARKDOWN_HTML_WHITELIST.union(

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #1314 (1a5768a) into main (ef7afc2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   79.39%   79.39%           
=======================================
  Files         109      109           
  Lines        4702     4702           
  Branches      635      635           
=======================================
  Hits         3733     3733           
  Misses        759      759           
  Partials      210      210           
Files Coverage Δ
src/wiki/conf/settings.py 97.14% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oscarmcm oscarmcm added the bug Confirmed bug label Oct 6, 2023
@oscarmcm oscarmcm merged commit afc465d into django-wiki:main Oct 6, 2023
15 checks passed
@orcephrye orcephrye deleted the html_whitelist_bugfix branch October 6, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants