Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket framing control #100

Closed
pgjones opened this issue Jun 27, 2019 · 5 comments
Closed

WebSocket framing control #100

pgjones opened this issue Jun 27, 2019 · 5 comments

Comments

@pgjones
Copy link
Contributor

pgjones commented Jun 27, 2019

Currently ASGI says nothing about WebSocket frames, which is in my view the best approach. However I've been asked about support for this, and I wanted to ask for views about an ASGI extension to allow framing support. Something like,

{"type": "websocket.send", "text": "hello", "message_finished": False}
{"type": "websocket.send", "text": "world", "message_finished": True}

?

@tomchristie
Copy link
Member

My first impression would be that we're probably in a phase of "should move slowly". I'm not sure we've got a good sense yet of what implications a proliferation of extensions will have further down the line. And it's not clear to me what critera we should use for determining what makes the cut wrt. new extensions.

But this may well just be a case of "I don't need this so I don't want it". 😃

@tomchristie
Copy link
Member

It would probably be good to start something like this with a clearer use-case motivation. Right now I can only see the issue framed in technical terms. What usage does this allow, and how does it effect the end-user experiance?

@andrewgodwin
Copy link
Member

The intent of ASGI was specifically to hide the ugliness of WebSocket frames (and PING frames in their entirety) from an application. I'd want to see a good explanation for why it's needed, like @tomchristie says.

@pgjones
Copy link
Contributor Author

pgjones commented Jun 28, 2019

I think these are good points, and I also find it hard to think of a use-case motivation, thanks for the discussion. I hope the original requester will add a use-case here otherwise I'll close.

@pgjones
Copy link
Contributor Author

pgjones commented Aug 11, 2019

I think this can be closed, lets see if anyone else expresses interest.

@pgjones pgjones closed this as completed Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants