Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Python 3.6 support, add Python 3.10 #301

Merged
merged 2 commits into from Mar 7, 2022
Merged

Deprecate Python 3.6 support, add Python 3.10 #301

merged 2 commits into from Mar 7, 2022

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Mar 7, 2022

  • Deprecate Python 3.6 and remove code to support Python versions < 3.7.
  • Add Python 3.10 to tox configuration.

@jalaziz jalaziz force-pushed the deprecate-py36 branch 2 times, most recently from bca5df0 to 2468c44 Compare March 7, 2022 19:33
@jalaziz
Deprecate Python 3.6 support, add Python 3.10
5def1b1 
* Deprecate Python 3.6 and remove code to support Python versions < 3.7.
* Add Python 3.10 to tox configuration.
@jalaziz
Copy link
Contributor Author

jalaziz commented Mar 7, 2022

@carltongibson Here you go! I can revert the pubsub.py change if you want to keep psuedo support for Python 3.6.

@jalaziz jalaziz mentioned this pull request Mar 7, 2022
Merged
carltongibson
carltongibson approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks! 👍

@carltongibson
Copy link
Member

@smithdc1 How do you mean?

https://github.com/django/channels_redis/pull/301/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fR20

@smithdc1
Copy link
Member

smithdc1 commented Mar 7, 2022

Ignore me. I tried to delete my comment but you are too quick!

I got sucked in looking at the tox file. Sorry for the noise!

@carltongibson carltongibson merged commit 8dc1762 into django:main Mar 7, 2022
@carltongibson
Copy link
Member

No problem. Thanks!

@jalaziz jalaziz deleted the deprecate-py36 branch March 7, 2022 19:45
fredfsh pushed a commit to cobalt-robotics/channels_redis that referenced this pull request Jun 20, 2023
@jalaziz @carltongibson
Deprecate Python 3.6 support, add Python 3.10 (django#301)
2117830 
* Deprecate Python 3.6 support, add Python 3.10
* Deprecate Python 3.6 and remove code to support Python versions < 3.7.
* Add Python 3.10 to tox configuration.
* Updated README/CHANGELOG.

Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jalaziz @carltongibson @smithdc1