Skip to content

Commit

Permalink
Fixed #827 -- For admin list_display functions without a short_descri…
Browse files Browse the repository at this point in the history
…ption, Django now converts underscores to spaces. Thanks, Aaron Swartz

git-svn-id: http://code.djangoproject.com/svn/django/trunk@1275 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
adrianholovaty committed Nov 17, 2005
1 parent 56e40c5 commit 33ffa72
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion django/contrib/admin/views/main.py
Expand Up @@ -361,7 +361,7 @@ def change_list(request, app_label, module_name):
try:
header = func.short_description
except AttributeError:
header = func.__name__
header = func.__name__.replace('_', ' ')
# Non-field list_display values don't get ordering capability.
raw_template.append('<th>%s</th>' % capfirst(header))
else:
Expand Down
7 changes: 4 additions & 3 deletions docs/tutorial02.txt
Expand Up @@ -331,12 +331,13 @@ Now the poll change list page looks like this:
You can click on the column headers to sort by those values -- except in the
case of the ``was_published_today`` header, because sorting by the output of
an arbitrary method is not supported. Also note that the column header for
``was_published_today`` is, by default, the name of the method. But you can
change that by giving that method a ``short_description`` attribute::
``was_published_today`` is, by default, the name of the method (with
underscores replaced with spaces). But you can change that by giving that
method a ``short_description`` attribute::

def was_published_today(self):
return self.pub_date.date() == datetime.date.today()
was_published_today.short_description = 'Was published today'
was_published_today.short_description = 'Published today?'


Let's add another improvement to the Poll change list page: Filters. Add the
Expand Down

0 comments on commit 33ffa72

Please sign in to comment.