Skip to content

Commit

Permalink
Fixed #4098 -- fixed a syntax error when reporting errors in "with" t…
Browse files Browse the repository at this point in the history
…emplate

tag. Thanks cephelo@gmail.com.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@5048 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
malcolmt committed Apr 21, 2007
1 parent e19ccda commit 539a7ab
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 2 additions & 2 deletions django/template/defaulttags.py
Expand Up @@ -990,7 +990,7 @@ def do_with(parser, token):
"""
Add a value to the context (inside of this block) for caching and easy
access.
For example::
{% with person.some_sql_method as total %}
Expand All @@ -999,7 +999,7 @@ def do_with(parser, token):
"""
bits = list(token.split_contents())
if len(bits) != 4 or bits[2] != "as":
raise TemplateSyntaxError, "%r expected format is 'value as name'" % tagname
raise TemplateSyntaxError, "%r expected format is 'value as name'" % bits[0]
var = parser.compile_filter(bits[1])
name = bits[3]
nodelist = parser.parse(('endwith',))
Expand Down
3 changes: 3 additions & 0 deletions tests/regressiontests/templates/tests.py
Expand Up @@ -654,6 +654,9 @@ def test_templates(self):
'with01': ('{% with dict.key as key %}{{ key }}{% endwith %}', {'dict': {'key':50}}, '50'),
'with02': ('{{ key }}{% with dict.key as key %}{{ key }}-{{ dict.key }}-{{ key }}{% endwith %}{{ key }}', {'dict': {'key':50}}, ('50-50-50', 'INVALID50-50-50INVALID')),

'with-error01': ('{% with dict.key xx key %}{{ key }}{% endwith %}', {'dict': {'key':50}}, template.TemplateSyntaxError),
'with-error02': ('{% with dict.key as %}{{ key }}{% endwith %}', {'dict': {'key':50}}, template.TemplateSyntaxError),

### NOW TAG ########################################################
# Simple case
'now01' : ('{% now "j n Y"%}', {}, str(datetime.now().day) + ' ' + str(datetime.now().month) + ' ' + str(datetime.now().year)),
Expand Down

0 comments on commit 539a7ab

Please sign in to comment.