Skip to content

Commit

Permalink
Small optimization on r12285
Browse files Browse the repository at this point in the history
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12292 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
spookylukey committed Jan 25, 2010
1 parent 89f8181 commit 65c1dfe
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion django/contrib/messages/storage/cookie.py
Expand Up @@ -92,8 +92,9 @@ def _store(self, messages, response, remove_oldest=True, *args, **kwargs):
if self.max_cookie_size: if self.max_cookie_size:
# data is going to be stored eventually by CompatCookie, which # data is going to be stored eventually by CompatCookie, which
# adds it's own overhead, which we must account for. # adds it's own overhead, which we must account for.
cookie = CompatCookie() # create outside the loop
def stored_length(val): def stored_length(val):
return len(CompatCookie().value_encode(val)[1]) return len(cookie.value_encode(val)[1])


while encoded_data and stored_length(encoded_data) > self.max_cookie_size: while encoded_data and stored_length(encoded_data) > self.max_cookie_size:
if remove_oldest: if remove_oldest:
Expand Down

0 comments on commit 65c1dfe

Please sign in to comment.