Skip to content

Commit

Permalink
Fixed #19291 -- Completed deprecation of ADMIN_MEDIA_PREFIX.
Browse files Browse the repository at this point in the history
  • Loading branch information
aaugustin committed Nov 17, 2012
1 parent 778b8bd commit 9b755a2
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 32 deletions.
3 changes: 0 additions & 3 deletions django/conf/__init__.py
Expand Up @@ -110,9 +110,6 @@ class BaseSettings(object):
def __setattr__(self, name, value):
if name in ("MEDIA_URL", "STATIC_URL") and value and not value.endswith('/'):
raise ImproperlyConfigured("If set, %s must end with a slash" % name)
elif name == "ADMIN_MEDIA_PREFIX":
warnings.warn("The ADMIN_MEDIA_PREFIX setting has been removed; "
"use STATIC_URL instead.", DeprecationWarning)
elif name == "ALLOWED_INCLUDE_ROOTS" and isinstance(value, six.string_types):
raise ValueError("The ALLOWED_INCLUDE_ROOTS setting must be set "
"to a tuple, not a string.")
Expand Down
15 changes: 0 additions & 15 deletions django/contrib/admin/templatetags/adminmedia.py

This file was deleted.

9 changes: 5 additions & 4 deletions docs/internals/deprecation.txt
Expand Up @@ -140,6 +140,11 @@ these changes.
removed. In its place use
:class:`~django.contrib.staticfiles.handlers.StaticFilesHandler`.

* The template tags library ``adminmedia`` and the template tag ``{%
admin_media_prefix %}`` will be removed in favor of the generic static files
handling. (This is faster than the usual deprecation path; see the
:doc:`Django 1.4 release notes</releases/1.4>`.)

* The :ttag:`url` and :ttag:`ssi` template tags will be
modified so that the first argument to each tag is a template variable, not
an implied string. In 1.4, this behavior is provided by a version of the tag
Expand Down Expand Up @@ -232,10 +237,6 @@ these changes.
:setting:`LOGGING` setting should include this filter explicitly if
it is desired.

* The template tag
:func:`django.contrib.admin.templatetags.adminmedia.admin_media_prefix`
will be removed in favor of the generic static files handling.

* The builtin truncation functions :func:`django.utils.text.truncate_words`
and :func:`django.utils.text.truncate_html_words` will be removed in
favor of the ``django.utils.text.Truncator`` class.
Expand Down
10 changes: 0 additions & 10 deletions docs/ref/settings.txt
Expand Up @@ -2210,16 +2210,6 @@ The default value for the X-Frame-Options header used by
Deprecated settings
===================

.. setting:: ADMIN_MEDIA_PREFIX

ADMIN_MEDIA_PREFIX
------------------

.. deprecated:: 1.4
This setting has been obsoleted by the ``django.contrib.staticfiles`` app
integration. See the :doc:`Django 1.4 release notes</releases/1.4>` for
more information.

.. setting:: AUTH_PROFILE_MODULE

AUTH_PROFILE_MODULE
Expand Down
5 changes: 5 additions & 0 deletions docs/releases/1.5.txt
Expand Up @@ -574,6 +574,11 @@ Miscellaneous
HTML validation against pre-HTML5 Strict DTDs, you should add a div around it
in your pages.

* The template tags library ``adminmedia``, which only contained the
deprecated template tag ``{% admin_media_prefix %}``, was removed.
Attempting to load it with ``{% load adminmedia %}`` will fail. If your
templates still contain that line you must remove it.

Features deprecated in 1.5
==========================

Expand Down

0 comments on commit 9b755a2

Please sign in to comment.