Skip to content

Commit

Permalink
Fixed #20242 - Added a regression test for prefetch_related.
Browse files Browse the repository at this point in the history
Issue was fixed by removal of chunked reads from
QuerySet iteration in 7067924.

Thanks Simeon Visser for the patch.
  • Loading branch information
timgraham committed May 28, 2013
1 parent 1fdc3d2 commit a2967d5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Expand Up @@ -594,6 +594,7 @@ answer newbie questions, and generally made Django that much better:
I.S. van Oostveen <v.oostveen@idca.nl>
viestards.lists@gmail.com
George Vilches <gav@thataddress.com>
Simeon Visser <http://simeonvisser.com>
Vlado <vlado@labath.org>
Zachary Voase <zacharyvoase@gmail.com>
Marijn Vriens <marijn@metronomo.cl>
Expand Down
10 changes: 10 additions & 0 deletions tests/prefetch_related/tests.py
Expand Up @@ -107,6 +107,16 @@ def test_exists(self):
qs = Book.objects.prefetch_related('first_time_authors')
[b.first_time_authors.exists() for b in qs]

def test_in_and_prefetch_related(self):
"""
Regression test for #20242 - QuerySet "in" didn't work the first time
when using prefetch_related. This was fixed by the removal of chunked
reads from QuerySet iteration in
70679243d1786e03557c28929f9762a119e3ac14.
"""
qs = Book.objects.prefetch_related('first_time_authors')
self.assertTrue(qs[0] in qs)

def test_clear(self):
"""
Test that we can clear the behavior by calling prefetch_related()
Expand Down

0 comments on commit a2967d5

Please sign in to comment.