Permalink
Browse files

Fixed #689 -- Added a middleware and authentication backend to contri…

…b.auth for supporting external authentication solutions. Thanks to all who contributed to this patch, including Ian Holsman, garthk, Koen Biermans, Marc Fargas, ekarulf, and Ramiro Morales.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@10063 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 7be4b9a commit b994387d8d9ff3b19d3ab04d3b4ac69d5dd68ea2 @gdub gdub committed Mar 15, 2009
@@ -78,3 +78,64 @@ def get_user(self, user_id):
return User.objects.get(pk=user_id)
except User.DoesNotExist:
return None
+
+
+class RemoteUserBackend(ModelBackend):
+ """
+ This backend is to be used in conjunction with the ``RemoteUserMiddleware``
+ found in the middleware module of this package, and is used when the server
+ is handling authentication outside of Django.
+
+ By default, the ``authenticate`` method creates ``User`` objects for
+ usernames that don't already exist in the database. Subclasses can disable
+ this behavior by setting the ``create_unknown_user`` attribute to
+ ``False``.
+ """
+
+ # Create a User object if not already in the database?
+ create_unknown_user = True
+
+ def authenticate(self, remote_user):
+ """
+ The username passed as ``remote_user`` is considered trusted. This
+ method simply returns the ``User`` object with the given username,
+ creating a new ``User`` object if ``create_unknown_user`` is ``True``.
+
+ Returns None if ``create_unknown_user`` is ``False`` and a ``User``
+ object with the given username is not found in the database.
+ """
+ if not remote_user:
+ return
+ user = None
+ username = self.clean_username(remote_user)
+
+ # Note that this could be accomplished in one try-except clause, but
+ # instead we use get_or_create when creating unknown users since it has
+ # built-in safeguards for multiple threads.
+ if self.create_unknown_user:
+ user, created = User.objects.get_or_create(username=username)
+ if created:
+ user = self.configure_user(user)
+ else:
+ try:
+ user = User.objects.get(username=username)
+ except User.DoesNotExist:
+ pass
+ return user
+
+ def clean_username(self, username):
+ """
+ Performs any cleaning on the "username" prior to using it to get or
+ create the user object. Returns the cleaned username.
+
+ By default, returns the username unchanged.
+ """
+ return username
+
+ def configure_user(self, user):
+ """
+ Configures a user after creation and returns the updated user.
+
+ By default, returns the user unmodified.
+ """
+ return user
@@ -1,12 +1,81 @@
+from django.contrib import auth
+from django.core.exceptions import ImproperlyConfigured
+
+
class LazyUser(object):
def __get__(self, request, obj_type=None):
if not hasattr(request, '_cached_user'):
from django.contrib.auth import get_user
request._cached_user = get_user(request)
return request._cached_user
+
class AuthenticationMiddleware(object):
def process_request(self, request):
assert hasattr(request, 'session'), "The Django authentication middleware requires session middleware to be installed. Edit your MIDDLEWARE_CLASSES setting to insert 'django.contrib.sessions.middleware.SessionMiddleware'."
request.__class__.user = LazyUser()
return None
+
+
+class RemoteUserMiddleware(object):
+ """
+ Middleware for utilizing web-server-provided authentication.
+
+ If request.user is not authenticated, then this middleware attempts to
+ authenticate the username passed in the ``REMOTE_USER`` request header.
+ If authentication is successful, the user is automatically logged in to
+ persist the user in the session.
+
+ The header used is configurable and defaults to ``REMOTE_USER``. Subclass
+ this class and change the ``header`` attribute if you need to use a
+ different header.
+ """
+
+ # Name of request header to grab username from. This will be the key as
+ # used in the request.META dictionary, i.e. the normalization of headers to
+ # all uppercase and the addition of "HTTP_" prefix apply.
+ header = "REMOTE_USER"
+
+ def process_request(self, request):
+ # AuthenticationMiddleware is required so that request.user exists.
+ if not hasattr(request, 'user'):
+ raise ImproperlyConfigured(
+ "The Django remote user auth middleware requires the"
+ " authentication middleware to be installed. Edit your"
+ " MIDDLEWARE_CLASSES setting to insert"
+ " 'django.contrib.auth.middleware.AuthenticationMiddleware'"
+ " before the RemoteUserMiddleware class.")
+ try:
+ username = request.META[self.header]
+ except KeyError:
+ # If specified header doesn't exist then return (leaving
+ # request.user set to AnonymousUser by the
+ # AuthenticationMiddleware).
+ return
+ # If the user is already authenticated and that user is the user we are
+ # getting passed in the headers, then the correct user is already
+ # persisted in the session and we don't need to continue.
+ if request.user.is_authenticated():
+ if request.user.username == self.clean_username(username, request):
+ return
+ # We are seeing this user for the first time in this session, attempt
+ # to authenticate the user.
+ user = auth.authenticate(remote_user=username)
+ if user:
+ # User is valid. Set request.user and persist user in the session
+ # by logging the user in.
+ request.user = user
+ auth.login(request, user)
+
+ def clean_username(self, username, request):
+ """
+ Allows the backend to clean the username, if the backend defines a
+ clean_username method.
+ """
+ backend_str = request.session[auth.BACKEND_SESSION_KEY]
+ backend = auth.load_backend(backend_str)
+ try:
+ username = backend.clean_username(username)
+ except AttributeError: # Backend has no clean_username method.
+ pass
+ return username
@@ -1,6 +1,9 @@
from django.contrib.auth.tests.basic import BASIC_TESTS
-from django.contrib.auth.tests.views import PasswordResetTest, ChangePasswordTest
+from django.contrib.auth.tests.views \
+ import PasswordResetTest, ChangePasswordTest
from django.contrib.auth.tests.forms import FORM_TESTS
+from django.contrib.auth.tests.remote_user \
+ import RemoteUserTest, RemoteUserNoCreateTest, RemoteUserCustomTest
from django.contrib.auth.tests.tokens import TOKEN_GENERATOR_TESTS
# The password for the fixture data users is 'password'
@@ -0,0 +1,169 @@
+from datetime import datetime
+
+from django.conf import settings
+from django.contrib.auth.backends import RemoteUserBackend
+from django.contrib.auth.models import AnonymousUser, User
+from django.test import TestCase
+
+
+class RemoteUserTest(TestCase):
+
+ middleware = 'django.contrib.auth.middleware.RemoteUserMiddleware'
+ backend = 'django.contrib.auth.backends.RemoteUserBackend'
+
+ # Usernames to be passed in REMOTE_USER for the test_known_user test case.
+ known_user = 'knownuser'
+ known_user2 = 'knownuser2'
+
+ def setUp(self):
+ self.curr_middleware = settings.MIDDLEWARE_CLASSES
+ self.curr_auth = settings.AUTHENTICATION_BACKENDS
+ settings.MIDDLEWARE_CLASSES += (self.middleware,)
+ settings.AUTHENTICATION_BACKENDS = (self.backend,)
+
+ def test_no_remote_user(self):
+ """
+ Tests requests where no remote user is specified and insures that no
+ users get created.
+ """
+ num_users = User.objects.count()
+
+ response = self.client.get('/')
+ self.assert_(isinstance(response.context['user'], AnonymousUser))
+ self.assertEqual(User.objects.count(), num_users)
+
+ response = self.client.get('/', REMOTE_USER=None)
+ self.assert_(isinstance(response.context['user'], AnonymousUser))
+ self.assertEqual(User.objects.count(), num_users)
+
+ response = self.client.get('/', REMOTE_USER='')
+ self.assert_(isinstance(response.context['user'], AnonymousUser))
+ self.assertEqual(User.objects.count(), num_users)
+
+ def test_unknown_user(self):
+ """
+ Tests the case where the username passed in the header does not exist
+ as a User.
+ """
+ num_users = User.objects.count()
+ response = self.client.get('/', REMOTE_USER='newuser')
+ self.assertEqual(response.context['user'].username, 'newuser')
+ self.assertEqual(User.objects.count(), num_users + 1)
+ User.objects.get(username='newuser')
+
+ # Another request with same user should not create any new users.
+ response = self.client.get('/', REMOTE_USER='newuser')
+ self.assertEqual(User.objects.count(), num_users + 1)
+
+ def test_known_user(self):
+ """
+ Tests the case where the username passed in the header is a valid User.
+ """
+ User.objects.create(username='knownuser')
+ User.objects.create(username='knownuser2')
+ num_users = User.objects.count()
+ response = self.client.get('/', REMOTE_USER=self.known_user)
+ self.assertEqual(response.context['user'].username, 'knownuser')
+ self.assertEqual(User.objects.count(), num_users)
+ # Test that a different user passed in the headers causes the new user
+ # to be logged in.
+ response = self.client.get('/', REMOTE_USER=self.known_user2)
+ self.assertEqual(response.context['user'].username, 'knownuser2')
+ self.assertEqual(User.objects.count(), num_users)
+
+ def test_last_login(self):
+ """
+ Tests that a user's last_login is set the first time they make a
+ request but not updated in subsequent requests with the same session.
+ """
+ user = User.objects.create(username='knownuser')
+ # Set last_login to something so we can determine if it changes.
+ default_login = datetime(2000, 1, 1)
+ user.last_login = default_login
+ user.save()
+
+ response = self.client.get('/', REMOTE_USER=self.known_user)
+ self.assertNotEqual(default_login, response.context['user'].last_login)
+
+ user = User.objects.get(username='knownuser')
+ user.last_login = default_login
+ user.save()
+ response = self.client.get('/', REMOTE_USER=self.known_user)
+ self.assertEqual(default_login, response.context['user'].last_login)
+
+ def tearDown(self):
+ """Restores settings to avoid breaking other tests."""
+ settings.MIDDLEWARE_CLASSES = self.curr_middleware
+ settings.AUTHENTICATION_BACKENDS = self.curr_auth
+
+
+class RemoteUserNoCreateBackend(RemoteUserBackend):
+ """Backend that doesn't create unknown users."""
+ create_unknown_user = False
+
+
+class RemoteUserNoCreateTest(RemoteUserTest):
+ """
+ Contains the same tests as RemoteUserTest, but using a custom auth backend
+ class that doesn't create unknown users.
+ """
+
+ backend =\
+ 'django.contrib.auth.tests.remote_user.RemoteUserNoCreateBackend'
+
+ def test_unknown_user(self):
+ num_users = User.objects.count()
+ response = self.client.get('/', REMOTE_USER='newuser')
+ self.assert_(isinstance(response.context['user'], AnonymousUser))
+ self.assertEqual(User.objects.count(), num_users)
+
+
+class CustomRemoteUserBackend(RemoteUserBackend):
+ """
+ Backend that overrides RemoteUserBackend methods.
+ """
+
+ def clean_username(self, username):
+ """
+ Grabs username before the @ character.
+ """
+ return username.split('@')[0]
+
+ def configure_user(self, user):
+ """
+ Sets user's email address.
+ """
+ user.email = 'user@example.com'
+ user.save()
+ return user
+
+
+class RemoteUserCustomTest(RemoteUserTest):
+ """
+ Tests a custom RemoteUserBackend subclass that overrides the clean_username
+ and configure_user methods.
+ """
+
+ backend =\
+ 'django.contrib.auth.tests.remote_user.CustomRemoteUserBackend'
+ # REMOTE_USER strings with e-mail addresses for the custom backend to
+ # clean.
+ known_user = 'knownuser@example.com'
+ known_user2 = 'knownuser2@example.com'
+
+ def test_known_user(self):
+ """
+ The strings passed in REMOTE_USER should be cleaned and the known users
+ should not have been configured with an email address.
+ """
+ super(RemoteUserCustomTest, self).test_known_user()
+ self.assertEqual(User.objects.get(username='knownuser').email, '')
+ self.assertEqual(User.objects.get(username='knownuser2').email, '')
+
+ def test_unknown_user(self):
+ """
+ The unknown user created should be configured with an email address.
+ """
+ super(RemoteUserCustomTest, self).test_unknown_user()
+ newuser = User.objects.get(username='newuser')
+ self.assertEqual(newuser.email, 'user@example.com')
Oops, something went wrong. Retry.

0 comments on commit b994387

Please sign in to comment.