Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #11907 -- EmailField now runs strip() on its input. This means …

…mistakenly including leading or trailing spaces will not cause a validation error, and clean() will remove those spaces. Thanks, krisneuharth, djansoft and SmileyChris

git-svn-id: http://code.djangoproject.com/svn/django/trunk@13997 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit bf0947a4743ce7df748f6e78a3d6e7d9e4f6cf5d 1 parent edd767d
Adrian Holovaty adrianholovaty authored
Showing with 5 additions and 0 deletions.
  1. +4 −0 django/forms/fields.py
  2. +1 −0  tests/regressiontests/forms/fields.py
4 django/forms/fields.py
View
@@ -448,6 +448,10 @@ class EmailField(CharField):
}
default_validators = [validators.validate_email]
+ def clean(self, value):
+ value = self.to_python(value).strip()
+ return super(EmailField, self).clean(value)
+
class FileField(Field):
widget = ClearableFileInput
default_error_messages = {
1  tests/regressiontests/forms/fields.py
View
@@ -430,6 +430,7 @@ def test_emailfield_33(self):
self.assertEqual(u'', f.clean(''))
self.assertEqual(u'', f.clean(None))
self.assertEqual(u'person@example.com', f.clean('person@example.com'))
+ self.assertEqual(u'example@example.com', f.clean(' example@example.com \t \t '))
self.assertRaisesErrorWithMessage(ValidationError, "[u'Enter a valid e-mail address.']", f.clean, 'foo')
self.assertRaisesErrorWithMessage(ValidationError, "[u'Enter a valid e-mail address.']", f.clean, 'foo@')
self.assertRaisesErrorWithMessage(ValidationError, "[u'Enter a valid e-mail address.']", f.clean, 'foo@bar')
Please sign in to comment.
Something went wrong with that request. Please try again.