comment_will_be_sent can cause a 400, not a 403

Doc cleanup for django.contrib.comments.signals.comment_will_be_sent If a receiver returns False, an HttpResponse with status code 400 is returned. A test case already exists confirming this behavior. Updated docs to reflect reality.
django · Nov 16, 2012 · d8ee46a · d8ee46a
1 parent ff0d312
commit d8ee46a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/django/contrib/comments/signals.py b/django/contrib/comments/signals.py
@@ -6,7 +6,7 @@
 # Sent just before a comment will be posted (after it's been approved and
 # moderated; this can be used to modify the comment (in place) with posting
 # details or other such actions. If any receiver returns False the comment will be
-# discarded and a 403 (not allowed) response. This signal is sent at more or less
+# discarded and a 400 response. This signal is sent at more or less
 # the same time (just before, actually) as the Comment object's pre-save signal,
 # except that the HTTP request is sent along with this signal.
 comment_will_be_posted = Signal(providing_args=["comment", "request"])

diff --git a/docs/ref/contrib/comments/signals.txt b/docs/ref/contrib/comments/signals.txt
@@ -20,8 +20,8 @@ Sent just before a comment will be saved, after it's been sanity checked and
 submitted. This can be used to modify the comment (in place) with posting
 details or other such actions.
 
-If any receiver returns ``False`` the comment will be discarded and a 403 (not
-allowed) response will be returned.
+If any receiver returns ``False`` the comment will be discarded and a 400
+response will be returned.
 
 This signal is sent at more or less the same time (just before, actually) as the
 ``Comment`` object's :data:`~django.db.models.signals.pre_save` signal.