Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized containment check in ChoicesMeta. #12221

Merged
merged 1 commit into from Dec 16, 2019
Merged

Optimized containment check in ChoicesMeta. #12221

merged 1 commit into from Dec 16, 2019

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Dec 15, 2019

No description provided.

@cool-RR cool-RR marked this pull request as ready for review December 15, 2019 20:35
@cool-RR
Copy link
Contributor Author

cool-RR commented Dec 15, 2019

@shaib

shaib
shaib approved these changes Dec 15, 2019
View reviewed changes
Copy link
Member

@shaib shaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ngnpope
ngnpope approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@felixxm felixxm changed the title Optimize ChoicesMeta containment check Optimized containment check in ChoicesMeta. Dec 16, 2019
@felixxm
Copy link
Member

felixxm commented Dec 16, 2019

@cool-RR Thanks 👍 Welcome aboard ⛵

@felixxm felixxm merged commit 972d93a into django:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaib shaib shaib approved these changes

@ngnpope ngnpope ngnpope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cool-RR @felixxm @shaib @ngnpope